Skip to content
This repository was archived by the owner on Mar 21, 2024. It is now read-only.

Fix length problem in SSL Cosine LR#638

Merged
ant0nsc merged 17 commits into
mainfrom
antonsc/simclr_cosine
Jan 21, 2022
Merged

Fix length problem in SSL Cosine LR#638
ant0nsc merged 17 commits into
mainfrom
antonsc/simclr_cosine

Conversation

@ant0nsc

@ant0nsc ant0nsc commented Jan 20, 2022

Copy link
Copy Markdown
Contributor

SimCLR cosine LR scheduler was getting wrong length information when the linear head dataset was longer than the encoder dataset.
Also, removed lots of obsolete pytest.skipif.is_windows() annotations.

Closes #636

Please follow the guidelines for PRs contained here. Checklist:

  • Ensure that your PR is small, and implements one change.
  • Add unit tests for all functions that you introduced or modified.
  • Run PyCharm's code cleanup tools on your Python files.
  • Link the correct GitHub issue for tracking.
  • Update the Changelog file: Describe your change in terms of
    Added/Changed/Removed/... in the "Upcoming" section.
  • When merging your PR, replace the default merge message with a description of your PR,
    and if needed a motivation why that change was required.

@ant0nsc ant0nsc enabled auto-merge (squash) January 20, 2022 14:41

@maxilse maxilse left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ant0nsc ant0nsc disabled auto-merge January 21, 2022 10:20
Comment thread Tests/SSL/test_data_modules.py
Comment thread Tests/SSL/test_ssl_containers.py

@vale-salvatelli vale-salvatelli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ant0nsc ant0nsc merged commit 56ee8b6 into main Jan 21, 2022
@ant0nsc ant0nsc deleted the antonsc/simclr_cosine branch January 21, 2022 15:02
Comment thread InnerEye/ML/SSL/encoders.py
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simclr cosine LR scheduler shows wrong behaviour when linear head dataset is longer than encoder datast

4 participants