Skip to content

User/amagraw/fix milli bytes bug #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pfrcks merged 3 commits into from
Aug 8, 2022
Merged

User/amagraw/fix milli bytes bug #805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd31327
fix bug
Aug 5, 2022
843a281
add vuln
Aug 5, 2022
c7296fb
fix bug
Aug 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .trivyignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ CVE-2022-1996

#dpkg vulnerability in ubuntu
CVE-2022-1304
CVE-2022-2509
7 changes: 6 additions & 1 deletion source/plugins/ruby/KubernetesApiClient.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,8 +751,13 @@ def getMetricNumericValue(metricName, metricVal)
metricValue.chomp!("k")
metricValue = Float(metricValue) * 1000.0 ** 1
elsif (metricValue.end_with?("m"))
#original value before downcase ending with M is megabyte and value ending with m is milli-byte
Comment thread
pfrcks marked this conversation as resolved.
metricValue.chomp!("m")
metricValue = Float(metricValue) * 1000.0 ** 2
Comment thread
pfrcks marked this conversation as resolved.
if (metricVal.end_with?("M"))
metricValue = Float(metricValue) * 1000.0 ** 2
else
metricValue = Float(metricValue) / 1000.0
end
elsif (metricValue.end_with?("g"))
metricValue.chomp!("g")
metricValue = Float(metricValue) * 1000.0 ** 3
Expand Down