Rashmi/april agent 2021#538
Merged
Merged
Conversation
rashmichandrashekar
commented
Apr 20, 2021
Contributor
- Making Job completion metric configurable
- Telemetry for omsagent requests and limits
vishiy
reviewed
Apr 20, 2021
vishiy
reviewed
Apr 20, 2021
vishiy
reviewed
Apr 20, 2021
| metricProps["Collections"].push(metricCollections) | ||
| metricItem["DataItems"].push(metricProps) | ||
| metricItems.push(metricItem) | ||
| #Telemetry about omsagent requests and limits |
Member
There was a problem hiding this comment.
Thanks for adding this. This works and also you are not adding additional calls. For future reference, you can easily pass this to us thru downward API. Please see here for reference -
vishiy
approved these changes
Apr 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.