Saaror osmdoc#523
Merged
Merged
Conversation
bradbax
previously approved these changes
Apr 1, 2021
bradbax
left a comment
There was a problem hiding this comment.
Consider changing query to:
InsightsMetrics
| where Name contains "envoy"
| summarize count() by Name
rashmichandrashekar
requested changes
Apr 5, 2021
|
|
||
| ## How to onboard Container Insights OSM monitoring? | ||
| OSM exposes Prometheus metrics which Container Insights can collect, for container insights agent to collect OSM metrics follow the following steps. | ||
| 1. Enable OSM to expose Prometheus metrics. Link [here](https://github.com/openservicemesh/osm/blob/main/docs/content/docs/tasks_usage/observability/_index.md) |
Contributor
There was a problem hiding this comment.
The link needs to be updated to - https://github.com/openservicemesh/osm/blob/main/docs/content/docs/tasks_usage/metrics.md#metrics-scraping
Contributor
There was a problem hiding this comment.
Please update this section as we discussed offline. You can also add the issue here under a notes section until it is fixed - openservicemesh/osm#3062 (comment)
rashmichandrashekar
approved these changes
Apr 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OSM documentation. @bradbax @rashmichandrashekar