Skip to content

Prometheus scraping from sidecar and OSM changes#515

Merged
rashmichandrashekar merged 183 commits into
ci_devfrom
rashmi/osm
Mar 25, 2021
Merged

Prometheus scraping from sidecar and OSM changes#515
rashmichandrashekar merged 183 commits into
ci_devfrom
rashmi/osm

Conversation

@rashmichandrashekar

@rashmichandrashekar rashmichandrashekar commented Mar 17, 2021

Copy link
Copy Markdown
Contributor

Changelist-

  1. Move custom prometheus to sidecar when environment variable is set.
  2. Provide support for OSM metric scraping
  3. Removed wireserver calls to get certs
  4. Addition of sidecar container
  5. Providing Label and Field selector options for custom prometheus scraping
  6. Latest telegraf build

Comment thread kubernetes/omsagent.yaml
Comment thread kubernetes/omsagent.yaml
Comment thread kubernetes/windows/main.ps1
Comment thread kubernetes/windows/main.ps1
Comment thread kubernetes/windows/main.ps1
Comment thread kubernetes/windows/main.ps1
Comment thread scripts/build/windows/install-build-pre-requisites.ps1
ganga1980
ganga1980 previously approved these changes Mar 25, 2021

@ganga1980 ganga1980 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some follow up questions, please help on answering them.

Have addressed all your questions. Let me know if anything is ambiguous.

@rashmichandrashekar rashmichandrashekar merged commit 4d386ce into ci_dev Mar 25, 2021
@rashmichandrashekar rashmichandrashekar deleted the rashmi/osm branch April 6, 2021 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants