Fix for zero fill metrics leaking in unsupported regions#423
Merged
Conversation
ganga1980
reviewed
Aug 6, 2020
| podNamespaceDimValue = key_elements[1] | ||
| podControllerNameDimValue = key_elements[2] | ||
| podPhaseDimValue = key_elements[3] | ||
| # get dimension values by key |
Contributor
There was a problem hiding this comment.
bunch of whitespaces and i think, we need to get rid off these to have cleaner code. I use this setting in vscode "files.trimTrailingWhitespace": true to avoid getting these whitespaces.
Can you add this settings "files.trimTrailingWhitespace": true to your vs code, File->Preferences->settings and push the update so these will get resolved automatically.
Contributor
Author
There was a problem hiding this comment.
this is coming from formatter. I have ruby formatter that is formatting the code
ganga1980
approved these changes
Aug 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding check for zero filled metrics since these were leaking for unsupported regions