Skip to content

Add an error handling case to ignore volumes that return File Not Found #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikmav merged 1 commit into from
Mar 25, 2024
Merged

Add an error handling case to ignore volumes that return File Not Found #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/Windows/VolumeInfoCache.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ public VolumeInfo GetVolumeForPath(string path)
"If the drive was added recently you may need to recreate the filesystem cache.");
}

private const int ERROR_FILE_NOT_FOUND = 2;
private const int ERROR_ACCESS_DENIED = 5;
private const int ERROR_NOT_READY = 21;
private const int ERROR_INVALID_PARAMETER = 87;
Expand All @@ -129,11 +130,13 @@ public VolumeInfo GetVolumeForPath(string path)
// - BitLocker can have a volume locked.
// - Access denied can imply a volume needing escalated privilege to get its metadata,
// sometimes indicating a Windows container volume.
// - Not found can occur as a timing issue on some machines.
if (lastErr == ERROR_UNRECOGNIZED_VOLUME ||
lastErr == ERROR_NOT_READY ||
lastErr == ERROR_INVALID_PARAMETER ||
lastErr == FVE_E_LOCKED_VOLUME ||
lastErr == ERROR_ACCESS_DENIED)
lastErr == ERROR_ACCESS_DENIED ||
lastErr == ERROR_FILE_NOT_FOUND)
{
return null;
}
Expand Down