Wrapping EverCBOR

[maxtropets]

This's purely reading CBORs, and lacking more exhausting tests, but is a good starting point, maybe?

[Copilot]

Pull request overview

This PR replaces the direct use of EverCBOR with a new CBOR wrapper abstraction (ccf::cbor). The primary purpose is to simplify CBOR parsing operations throughout the codebase by providing a higher-level, type-safe API.

Key Changes:

• Introduces a new CBOR wrapper library (src/crypto/cbor.h and src/crypto/cbor.cpp) that encapsulates EverCBOR operations
• Refactors UVM endorsement parsing to use the new wrapper, significantly reducing code complexity (from ~400 lines to ~100 lines in the decode functions)
• Updates error handling to use the new CBORDecodeError type consistently

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
src/crypto/cbor.h	Defines the new CBOR wrapper API with types and parsing functions
src/crypto/cbor.cpp	Implements the CBOR wrapper, including parsing and value extraction methods
src/node/uvm_endorsements.cpp	Refactors protected header decoding to use the new CBOR wrapper instead of raw EverCBOR calls
cmake/crypto.cmake	Adds the new cbor.cpp to the build configuration

Comments suppressed due to low confidence (1)

src/node/uvm_endorsements.cpp:343

• Missing closing brace for the namespace ccf block. The namespace opened at line 9 should be closed after line 168.

  }
}

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.