Skip to content

Support UVMs for ContainerPlat 0.2.10#7466

Merged
achamayou merged 7 commits intomicrosoft:mainfrom
maxtropets:f/uvm-endorsements-with-cwt
Nov 25, 2025
Merged

Support UVMs for ContainerPlat 0.2.10#7466
achamayou merged 7 commits intomicrosoft:mainfrom
maxtropets:f/uvm-endorsements-with-cwt

Conversation

@maxtropets
Copy link
Copy Markdown
Collaborator

@maxtropets maxtropets commented Nov 18, 2025

I'd like to deduplicate some of the COSE parsing as a follow-up, as well as migrate SVN to integer type, whereas this will go backported to 6.x as is.

@maxtropets maxtropets self-assigned this Nov 18, 2025
Copilot AI review requested due to automatic review settings November 18, 2025 14:14
@maxtropets maxtropets requested a review from a team as a code owner November 18, 2025 14:14
Comment thread src/node/uvm_endorsements.h Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds support for UVM endorsements in ContainerPlat version 0.2.10, which introduces a new format for encoding attestation information using CWT (CBOR Web Token) claims.

Key changes:

  • Adds parsing support for issuer (iss), subject (sub), and SVN from CWT claims in UVM endorsements
  • Registers a new trusted UVM root of trust with SVN 104
  • Introduces a new decoding function decode_protected_header_with_cwt for the updated format

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.

File Description
tests/uvm_endorsements/uvm_0.2.10.cose Adds test data file for the new UVM 0.2.10 endorsement format
src/node/uvm_endorsements.h Adds new trusted UVM root of trust entry for ContainerPlat with SVN 104
src/node/uvm_endorsements.cpp Implements CWT claims parsing and handles both old and new UVM endorsement formats
src/node/test/endorsements.cpp Updates test indices and adds comprehensive test case for UVM 0.2.10

Comment thread src/node/uvm_endorsements.cpp
Comment thread src/node/uvm_endorsements.h Outdated
Comment thread src/node/uvm_endorsements.cpp
Comment thread src/node/uvm_endorsements.cpp
Comment thread src/node/uvm_endorsements.h
Comment thread src/node/uvm_endorsements.cpp Outdated
Comment thread src/node/uvm_endorsements.h
@maxtropets maxtropets added auto-backport Automatically backport this PR to LTS branch 6.x-todo PRs which should be backported to 6.x labels Nov 18, 2025
@maxtropets maxtropets force-pushed the f/uvm-endorsements-with-cwt branch from e523c06 to aa9d58c Compare November 21, 2025 10:04
@maxtropets maxtropets removed auto-backport Automatically backport this PR to LTS branch 6.x-todo PRs which should be backported to 6.x labels Nov 21, 2025
@achamayou achamayou merged commit cffbad7 into microsoft:main Nov 25, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants