Support UVMs for ContainerPlat 0.2.10#7466
Merged
achamayou merged 7 commits intomicrosoft:mainfrom Nov 25, 2025
Merged
Conversation
maxtropets
commented
Nov 18, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for UVM endorsements in ContainerPlat version 0.2.10, which introduces a new format for encoding attestation information using CWT (CBOR Web Token) claims.
Key changes:
- Adds parsing support for issuer (iss), subject (sub), and SVN from CWT claims in UVM endorsements
- Registers a new trusted UVM root of trust with SVN 104
- Introduces a new decoding function
decode_protected_header_with_cwtfor the updated format
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| tests/uvm_endorsements/uvm_0.2.10.cose | Adds test data file for the new UVM 0.2.10 endorsement format |
| src/node/uvm_endorsements.h | Adds new trusted UVM root of trust entry for ContainerPlat with SVN 104 |
| src/node/uvm_endorsements.cpp | Implements CWT claims parsing and handles both old and new UVM endorsement formats |
| src/node/test/endorsements.cpp | Updates test indices and adds comprehensive test case for UVM 0.2.10 |
achamayou
reviewed
Nov 18, 2025
achamayou
reviewed
Nov 18, 2025
maxtropets
commented
Nov 18, 2025
e523c06 to
aa9d58c
Compare
achamayou
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to deduplicate some of the COSE parsing as a follow-up, as well as migrate SVN to integer type, whereas this will go backported to 6.x as is.