Check the endorsed tcb and chip id match those in the attestation.#7240
Merged
cjen1-msft merged 23 commits intomicrosoft:mainfrom Sep 12, 2025
Merged
Check the endorsed tcb and chip id match those in the attestation.#7240cjen1-msft merged 23 commits intomicrosoft:mainfrom
cjen1-msft merged 23 commits intomicrosoft:mainfrom
Conversation
cjen1-msft
commented
Sep 2, 2025
cjen1-msft
commented
Sep 2, 2025
achamayou
reviewed
Sep 3, 2025
achamayou
reviewed
Sep 3, 2025
achamayou
reviewed
Sep 3, 2025
achamayou
reviewed
Sep 3, 2025
achamayou
reviewed
Sep 4, 2025
achamayou
reviewed
Sep 4, 2025
achamayou
approved these changes
Sep 4, 2025
Co-authored-by: Amaury Chamayou <amaury@xargs.fr>
Co-authored-by: Amaury Chamayou <amaury@xargs.fr>
cjen1-msft
added a commit
to cjen1-msft/CCF
that referenced
this pull request
Sep 12, 2025
…icrosoft#7240) Co-authored-by: Amaury Chamayou <amchamay@microsoft.com> Co-authored-by: Amaury Chamayou <amaury@xargs.fr>
cjen1-msft
added a commit
that referenced
this pull request
Sep 15, 2025
Co-authored-by: Amaury Chamayou <amchamay@microsoft.com> Co-authored-by: Amaury Chamayou <amaury@xargs.fr> Co-authored-by: Eddy Ashton <ashton.eddy@gmail.com>
eddyashton
pushed a commit
to eddyashton/CCF
that referenced
this pull request
Oct 10, 2025
…icrosoft#7240) Co-authored-by: Amaury Chamayou <amchamay@microsoft.com> Co-authored-by: Amaury Chamayou <amaury@xargs.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds checks in
verify_snp_attestation_reportto check the tcb version in the retrieved endorsements against those in the attestation, and additionally validates the chip_id in the endorsements.If the relevant oids in the certificate are not set, then the check is ignored as the certificate must still have the correct root signature, and hence their omission can only be intentional.
Otherwise if the check fails, it will throw an exception.
Update:
Also refactored the attestation logic to live in a private .cpp file to clean up the public API surface.