Unhandled exception when receiving websocket error

[orgads]

It happens occasionally when the websocket connection returns 400.

Can be easily reproduced by providing a non-working domain:

    var directLine = new DirectLine({
      secret: <bot-secret>,
      domain: 'https://europe.directline.botframework.com/v3/directline'
    });

Trace:

Error: Unexpected server response: 400                                                           
    at ClientRequest.req.on (E:\Project\node_modules\ws\lib\websocket.js:559:5)                                                                                                       
    at ClientRequest.emit (events.js:159:13)                                                     
    at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:550:21)                
    at HTTPParser.parserOnHeadersComplete (_http_common.js:115:23)                               
    at TLSSocket.socketOnData (_http_client.js:439:20)                                           
    at TLSSocket.emit (events.js:159:13)                                                         
    at addChunk (_stream_readable.js:265:12)                                                     
    at readableAddChunk (_stream_readable.js:252:11)                                             
    at TLSSocket.Readable.push (_stream_readable.js:209:10)                                      
    at TLSWrap.onread (net.js:608:20)                                                            

[orgads]

#171 is a partial fix. At least it doesn't crash, but I'm not sure how to proceed from here. I need a way to notify the client. Can you suggest one?

[orgads]

Here is a MWE (you need to install nock):

globalThis.XMLHttpRequest = require('xhr2');
globalThis.WebSocket = require('ws');
import * as nock from 'nock';
import { DirectLine } from 'botframework-directlinejs';

const conversation = {
  conversationId: '123',
  token: '456',
  streamUrl: 'wss://google.com/'
};
nock('https://directline.botframework.com')
  .post('/v3/directline/conversations')
  .reply(200, JSON.stringify(conversation));
const directLine = new DirectLine({ secret: '1234' });
directLine.activity$
  .subscribe(
    activity => {
      if (activity.type === 'message')
        console.log("received activity ", activity.text);
    },
    error => {
      console.error(error);
    }
  );

[compulim]

Hi @orgads, this is recently fixed in #324. You should start seeing this fixed in @0.13.2-master.c6ecb71.

Please let us know if it resolves the issue. Thanks.