Skip to content

Change CompileSdk to 35 and Opt Out Edge to Edge#2895

Merged
mar-v-in merged 2 commits into
microg:masterfrom
p1gp1g:workaround-e2e
Jul 11, 2025
Merged

Change CompileSdk to 35 and Opt Out Edge to Edge#2895
mar-v-in merged 2 commits into
microg:masterfrom
p1gp1g:workaround-e2e

Conversation

@p1gp1g
Copy link
Copy Markdown
Contributor

@p1gp1g p1gp1g commented May 6, 2025

This is a workaround to disable edge to edge until it is properly supported by microg

This workaround is necessary for applications embedding microg lib with activities, like fido-core

This opt-out may be removed for a future SDK (36 ?), but it gives some time to implement edge to edge

@ale5000-git
Copy link
Copy Markdown
Member

ale5000-git commented May 6, 2025

@p1gp1g
Build fail:

Execution failed for task ':firebase-auth-core:verifyReleaseResources'.
> A failure occurred while executing com.android.build.gradle.tasks.VerifyLibraryResourcesTask$Action
   > Android resource linking failed
     ERROR: /home/runner/work/GmsCore/GmsCore/firebase-auth/core/build/intermediates/merged_res/release/values/values.xml:4227: AAPT: error: style attribute 'android:attr/windowOptOutEdgeToEdgeEnforcement' not found.

@ale5000-git
Copy link
Copy Markdown
Member

ale5000-git commented May 6, 2025

@p1gp1g
I have looked at it and this probably require bumping compileSdk that also require bumping the gradle build plugin.
I suggest to mark this as draft for now, so it is clear that it isn't ready but people will still be able to see it.

@p1gp1g
Copy link
Copy Markdown
Contributor Author

p1gp1g commented May 6, 2025

I didn't have that issue with publishToMavenLocal, maybe something with my cache ? I'm pushing another patch with a bump of compileSdk (it has a few other fixes)

@p1gp1g
Copy link
Copy Markdown
Contributor Author

p1gp1g commented May 6, 2025

@ale5000-git I've pushed the patch

@p1gp1g p1gp1g force-pushed the workaround-e2e branch from 9c8d156 to 1dd35dd Compare May 6, 2025 11:46
@p1gp1g p1gp1g changed the title Opt Out Edge to Edge Target SDK35 and Opt Out Edge to Edge May 6, 2025
@ale5000-git ale5000-git changed the title Target SDK35 and Opt Out Edge to Edge Change CompileSdk to 35 and Opt Out Edge to Edge May 6, 2025
@mar-v-in
Copy link
Copy Markdown
Member

@p1gp1g FYI, publishToMavenLocal does not run the verify tasks before.

@mar-v-in mar-v-in added this to the 0.3.9 milestone Jul 10, 2025
@mar-v-in mar-v-in merged commit c05372a into microg:master Jul 11, 2025
1 check passed
@mar-v-in
Copy link
Copy Markdown
Member

Thanks!

DaVinci9196 pushed a commit to DaVinci9196/GmsCore that referenced this pull request Jul 17, 2025
@p1gp1g
Copy link
Copy Markdown
Contributor Author

p1gp1g commented Aug 22, 2025

Unfortunately, Android 16 removed the edge-to-edge opt-out; so a proper edge-to-edge have to be implemented to support SDK 36+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants