Breaking: Move serialWrite from DeviceConnection to USB only#107
Merged
microbit-matt-hillsdon merged 1 commit intoappsfrom Mar 3, 2026
Merged
Breaking: Move serialWrite from DeviceConnection to USB only#107microbit-matt-hillsdon merged 1 commit intoappsfrom
microbit-matt-hillsdon merged 1 commit intoappsfrom
Conversation
…rfaces Serial is a USB-specific concern — Bluetooth has UART (different data model) and the Bluetooth implementation was just a stub. Remove serialWrite from the base DeviceConnection interface and add it to MicrobitUSBConnection instead. The radio bridge intentionally does not expose serialWrite as it would conflict with the serial protocol used to relay radio messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serial is a USB-specific concern — Bluetooth has UART (different data model) and the Bluetooth implementation was just a stub. Remove serialWrite from the base DeviceConnection interface and add it to MicrobitUSBConnection instead. The radio bridge intentionally does not expose serialWrite as it would conflict with the serial protocol used to relay radio messages.
Note this targets document-post-connection for now but will eventually be apps once those are reviewed.