Breaking: Switch to throwing DeviceError when not connected#104
Merged
microbit-matt-hillsdon merged 1 commit intoappsfrom Mar 3, 2026
Merged
Breaking: Switch to throwing DeviceError when not connected#104microbit-matt-hillsdon merged 1 commit intoappsfrom
microbit-matt-hillsdon merged 1 commit intoappsfrom
Conversation
Introduce a new code for the purpose. Previously we returned undefined in scenarios where you call the method either before connection or when unexpectedly disconnected. This can lead to errors being ignored or knock-on errors because you "know" you're connected but disconnects can happen at arbitrary points. Better to require the caller to handle an error.
| // TODO | ||
| } | ||
| assertConnected(this.connection); | ||
| // TODO |
Contributor
Author
There was a problem hiding this comment.
I'm going to pick this up separately as there's no plan to support serial for Bluetooth, if you want to try to implement some kind of serial over UART that's best done at the application level where you can consider the limitations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new code for the purpose.
Previously we returned undefined in scenarios where you call the method either before connection or when unexpectedly disconnected. This can lead to errors being ignored or knock-on errors because you "know" you're connected but disconnects can happen at arbitrary points. Better to require the caller to handle an error.