Closed
Conversation
Do the bare minimium to get private names to parse. Added `isPrivateName` flag to `Identifier` interface. Just accept all the baseline changes. TODO: parse for real, and fix baselines for real.
mheiber
pushed a commit
that referenced
this pull request
Jul 3, 2018
do a really rough, quick-and-dirty unblock-people job of letting #foo be parse-able. steps to test: npm run lint && npm test See https://bbgithub.dev.bloomberg.com/javascript-guild/typescript-private-fields/ quick start guide for seeing the AST CI testing coming soon
mheiber
pushed a commit
that referenced
this pull request
Jul 3, 2018
do a really rough, quick-and-dirty unblock-people job of letting #foo be parse-able. steps to test: npm run lint && npm test See https://bbgithub.dev.bloomberg.com/javascript-guild/typescript-private-fields/ quick start guide for seeing the AST CI testing coming soon
mheiber
pushed a commit
that referenced
this pull request
Jul 3, 2018
do a really rough, quick-and-dirty unblock-people job of letting #foo be parse-able. steps to test: npm run lint && npm test See https://bbgithub.dev.bloomberg.com/javascript-guild/typescript-private-fields/ quick start guide for seeing the AST CI testing coming soon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do the bare minimium to
get private names to parse.
Added
isPrivateNameflag toIdentifierinterface.Just accept all the baseline changes.
TODO: parse for real, and fix baselines
for real.