This repository was archived by the owner on Dec 1, 2023. It is now read-only.
fix(datepicker): unable to select the same date as minDate#2266
Merged
mgcrea merged 3 commits intomgcrea:masterfrom Feb 23, 2018
Merged
fix(datepicker): unable to select the same date as minDate#2266mgcrea merged 3 commits intomgcrea:masterfrom
mgcrea merged 3 commits intomgcrea:masterfrom
Conversation
Contributor
Author
|
@mgcrea, please review this PR. |
misino
approved these changes
Feb 22, 2018
daviddutch
pushed a commit
to daviddutch/angular-strap
that referenced
this pull request
Oct 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to passing string with 'Z' into Date constructor the date value is being offset by browser's timezone which is causing the the datepicker to disable the day which is passed as minDate. Effectively not allowing to select the date which is set as minDate. This will be reproducible for user on East of UTC.
To fix the issue, checking for 'Z' in the date string and excluding it to get the Date object with the expected date.