This repository was archived by the owner on Dec 1, 2023. It is now read-only.
feat(modal): 508 support in modal#2229
Merged
mgcrea merged 4 commits intomgcrea:masterfrom Jun 8, 2018
Merged
Conversation
added 2 commits
April 11, 2017 15:54
508 and screen-reader support in modal.
Fix the eslint erros with modal.js.
Contributor
Author
|
FYI, unit test cases are included in the feature commit. |
Remove the force flag from the modal tests.
Only apply the aria-hidden to the body element when the backdrop option is specified.
daviddutch
pushed a commit
to daviddutch/angular-strap
that referenced
this pull request
Oct 27, 2018
* feat(modal): 508 support in modal 508 and screen-reader support in modal. * fix(eslint): Modal eslint errors Fix the eslint erros with modal.js. * fix(modal): fix skipped tests Remove the force flag from the modal tests. * fix(modal): aria-hidden on body without backdrop Only apply the aria-hidden to the body element when the backdrop option is specified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
508 and screen-reader support in modal.