Conversation
Change-Id: Iaadb69157435bffc1a4853edad192d1dfe5e68d2
Change-Id: Ibc48538ef229ad9e2c86512d3963dd0ec17286fb
Changing the tab to handle keypress event for both space-bar and enter. The JAWS screen reader is instructing users to hit space-bar. Change-Id: I335758ca59605b7ade4be006f65d48bb3bafb4e8
Updating tabs to allow for access to the controller scope if needed. Change-Id: I7a6ee41ed6b8fc5d9988d89538291e58a6b63da3
Fixing JSHint issues with prior 508 commits.
|
Hi, Thanks for the PR and several fixes. Glad you are using this library in your product. I will gladly merge your work as long at unit tests are kept green. Finally, if you're willing to contribute significantly to this library either by maintaining it or adding new features, I could consider adding you as an official collaborator. Thanks! |
|
@mgcrea, thanks! Internally we have a built up control suite which is used across our various projects. I've been really pushing the guys to write unit tests on pretty much everything. You'll notice in this batch of commit notices that I forgot to remove the Change-Id. That's because we use Gerrit. My goal is to integrate unit tests into both our consumption of Angular-Strap and thus verify our internal commits against a build before code can be committed as well as using our internal Jenkins to do a build similar to what your Travis build does. Unfortunately, between getting my deliverables completed, reviewing our internal code, and insuring we're compliant with the projects we use it leaves me little to devote to our devops tasks. I have to sneak work on that stuff under the radar. So far I've gotten my team off of TFS and SVN to Git and having CI builds on every commit. We'll do better on the unit test cases in the future. I guarantee it! Thanks for merging our code! I may reach out to you soon regarding some 508 work that I'm doing on the datepicker. I have talked with our internal UX team about some changes we may have to make in our product regarding our implementation, but I may also have to reach out to TPG to get clarification on some functionality. Fortunately working with your code is a pleasure! |
This PR comprises of fixes we've made to the source for 508 issues.
Our product is undergoing an intense 508 validation by TPG and these are some of the first fixes we've completed. We have more fixes incoming with a major push on the Calendar component.