Skip to content

ninjabackend: add -fmodules as a dyndeps condition #15370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
mochaaP wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

ninjabackend: add -fmodules as a dyndeps condition #15370

mochaaP wants to merge 1 commit into from
+1 −1

Conversation

@mochaaP
Copy link
Contributor

@mochaaP mochaaP commented Dec 9, 2025

we previously only check for -fmodules-ts.

this could hypothetically be something like Compiler.get_cpp_modules_args for extensibility.

@mochaaP
ninjabackend: add -fmodules as a dyndeps condition
119fd4e 
we previously only check for -fmodules-ts.
@mochaaP mochaaP requested a review from jpakkane as a code owner December 9, 2025 21:52
@mochaaP mochaaP marked this pull request as draft December 9, 2025 22:24
@mochaaP
Copy link
Contributor Author

mochaaP commented Dec 9, 2025

TODO: add a method to the Compiler instance and use it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpakkane jpakkane Awaiting requested review from jpakkane jpakkane is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mochaaP