Add meshstack_location resource and local acceptance tests as PoC
#81
+918
−238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryde
reviewed
Dec 22, 2025
aacb9bd to
e7d1012
Compare
henryde
requested changes
Dec 23, 2025
b9cbcf4 to
f09fcc8
Compare
f09fcc8 to
23cd354
Compare
…via .env file later setting TF_ACC=1)
23cd354 to
336d1f1
Compare
henryde
approved these changes
Jan 7, 2026
Comment on lines
+219
to
+222
| Ref: struct { | ||
| Kind string `tfsdk:"kind"` | ||
| Name string `tfsdk:"name"` | ||
| }{ |
Contributor
There was a problem hiding this comment.
f: make this an explicit type instead of inlining it multiple times
Comment on lines
+129
to
+134
| "kind": schema.StringAttribute{ | ||
| MarkdownDescription: "meshObject type, always `meshLocation`.", | ||
| Computed: true, | ||
| Default: stringdefault.StaticString("meshLocation"), | ||
| PlanModifiers: []planmodifier.String{stringplanmodifier.UseStateForUnknown()}, | ||
| }, |
Contributor
There was a problem hiding this comment.
f: in order for this to plug cleanly into a platform resource location_ref.kind must be made optional there since it's currently always being set automatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs (internal) PR https://github.com/meshcloud/meshfed-release/pull/9088
See single commits in this PR.