Skip to content

Install build requirements for animate#177

Merged
stephankramer merged 3 commits into
mainfrom
skramer/animate-build-requirements
Jun 13, 2026
Merged

Install build requirements for animate#177
stephankramer merged 3 commits into
mainfrom
skramer/animate-build-requirements

Conversation

@stephankramer

Copy link
Copy Markdown
Member

Adds pip install -r animate/requirements-build.txt step before building/installing animate. This is needed in the release container because there firedrake is installed directly from a pypi wheel and thus build requirements like Cython and a recent enough setuptools are not available. In the main container firedrake has been built locally and thus these are available already. Adding steps in both cases though for consistency.

Addresses mesh-adaptation/animate#241

Adds `pip install -r animate/requirements-build.txt` step before
building/installing animate. This is needed in the release container
because there firedrake is installed directly from a pypi wheel and thus
build requirements like Cython and a recent enough setuptools are not
available. In the main container firedrake has been built locally and
thus these are available already. Adding steps in both cases though for
consistency.

See mesh-adaptation/animate#241
@stephankramer

Copy link
Copy Markdown
Member Author

@joewallwork : any idea why this PR hasn't triggered .github/workflows/docker_firedrake-parmmg_main.yml or .github/workflows/docker_firedrake-parmmg_release.yml ?

I'm feeling I'm missing something obvious...

@joewallwork

joewallwork commented Jun 12, 2026

Copy link
Copy Markdown
Member

@joewallwork : any idea why this PR hasn't triggered .github/workflows/docker_firedrake-parmmg_main.yml or .github/workflows/docker_firedrake-parmmg_release.yml ?

I'm feeling I'm missing something obvious...

For the release workflow, we do need to update the triggers in

- '.github/workflows/reusable_docker_build.yml'
- '.github/workflows/docker_firedrake-parmmg_release.yml'
- 'docker/Dockerfile.firedrake-parmmg'
- 'docker/Dockerfile.firedrake-um2n'
# Build and push the Docker container when these files get changed on the main branch
push:
branches:
- main
paths:
- '.github/workflows/reusable_docker_build.yml'
- '.github/workflows/docker_firedrake-parmmg_release.yml'
- 'docker/Dockerfile.firedrake-parmmg'
- 'docker/Dockerfile.firedrake-um2n'

to refer to the release version of the Dockerfile.

I have no idea why the other one hasn't triggered. I've been having a lot of issues with GitHub Actions getting triggered in other repos recently.

@stephankramer stephankramer force-pushed the skramer/animate-build-requirements branch from ad27b16 to 1953e60 Compare June 12, 2026 15:05
@stephankramer stephankramer force-pushed the skramer/animate-build-requirements branch from 52cb537 to 99cdbae Compare June 13, 2026 10:28
@stephankramer stephankramer merged commit 96db3e5 into main Jun 13, 2026
7 checks passed
@stephankramer

Copy link
Copy Markdown
Member Author

I was missing something obvious: some of the workflows had been "disabled due to inactivity (>60 days)"

@stephankramer stephankramer deleted the skramer/animate-build-requirements branch June 13, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants