Draft
Conversation
- remove unnecessary context, use props instead - split config, make it more typed - add class and style to the widget - remove unnecessary hooks, use simple utils instead - update icons and tiles
- hide ean128 for qrcode - change code value to expression - add button position and card view config - implement layout, styling and icon
- static value consistency checks - dynamic value warnings and runtime error alert
r0b1n
reviewed
Feb 13, 2026
| displayValue: boolean; | ||
| allowDownload: boolean; | ||
| downloadAriaLabel?: string; | ||
| buttonPosition: "top" | "bottom"; |
Collaborator
There was a problem hiding this comment.
Maybe having this prop inside DownloadButtonConfig itself makes more sense.
- enable displayValue for addons - improve conditional visibility for certain configurations - improve descriptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Description