Skip to content

[master < MG] Make mgclient compile on Ubuntu 22.04#41

Merged
antaljanosbenjamin merged 19 commits into
masterfrom
MG-fix-warning-on-gcc-11.4
Jun 14, 2022
Merged

[master < MG] Make mgclient compile on Ubuntu 22.04#41
antaljanosbenjamin merged 19 commits into
masterfrom
MG-fix-warning-on-gcc-11.4

Conversation

@antaljanosbenjamin

@antaljanosbenjamin antaljanosbenjamin commented Jun 13, 2022

Copy link
Copy Markdown
Contributor

On the side I changed a lot things:

  1. Updated CI to run on Ubuntu 22.04 (root cause)
  2. To fix warnings on newer compilers:
    1. Updated OpenSSL related function calls
    2. Wrapped gmock/gmock.h in a header file to ignore warning coming from it
    3. Reordered some includes
  3. Extended our CI to run on multiple Ubuntu versions
  4. Replaced NULL by nullptr in the C++ tests (for the new functions I didn't want to use NULL and also didn't want to mix the two)

@antaljanosbenjamin antaljanosbenjamin force-pushed the MG-fix-warning-on-gcc-11.4 branch from 911eae3 to a22160d Compare June 13, 2022 22:03
@antaljanosbenjamin antaljanosbenjamin requested review from 42jeremy, gitbuda, jbajic, kostasrim and spacejam and removed request for gitbuda and kostasrim June 13, 2022 22:04
@antaljanosbenjamin antaljanosbenjamin force-pushed the MG-fix-warning-on-gcc-11.4 branch from a22160d to 2623fd1 Compare June 13, 2022 22:06

@gitbuda gitbuda left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More than enough 😄

@antaljanosbenjamin antaljanosbenjamin merged commit 1cfea03 into master Jun 14, 2022
antaljanosbenjamin added a commit that referenced this pull request Jun 14, 2022
antaljanosbenjamin pushed a commit that referenced this pull request Jun 14, 2022
* Update CI to run on Ubuntu 22.04

* Fix include order and its formatting

* Make CI compiler version independent

* Fix clang-format issues

* Avoid deprecated low level API in OpenSSL 3.0

* Call OPENSSL_init_crypto to initialize ciphers required for RSA

* Ignore warning from gmock

* Parallelize compilation in CI

* Ignore unknown warning option to make gmock_wrapper compile with older compilers

* Restrict ingoring warnings for clang and gcc

* Replace NULL by nullptr in tests

* Explicitly ignore macOS for diagnostic pragma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants