Can't compile mgclient on Fedora 37

[Elvino00]

Hi,
When I try to compile mgclient on my pc (Fedora 37 x64 bit NOT ARM) i get this cmake error:

Here is the log file:
CMakeOutput.log

[gitbuda]

Hi @Elvino00! Thanks for reporting. This is interesting. It seems like there are multiple problems on Fedora (so far, we haven't tested on Fedora). I'll try to recreate it soon (latest in the next day or so), but this seems like something easy to fix.

What's your version of CMake?

[Elvino00]

Hi @Elvino00! Thanks for reporting. This is interesting. It seems like there are multiple problems on Fedora (so far, we haven't tested on Fedora). I'll try to recreate it soon (latest in the next day or so), but this seems like something easy to fix.

What's your version of CMake?

cmake version 3.25.2

[gitbuda]

I've run Fedora 37 in a Docker container. Please take a look at the config below, and it seems to be working. The whole error message on your end seems very weird because the project call is there, Linux should be detected because the standard CMake command is used for that... Long story short, I'm not sure what is happening...

Could you try to pull the latest commit from mgclient master branch + try to build and/or try to update CMake to 3.26.0-rc, which should be available on the regular Fedora repo (I haven't added any specific repo)?

Also, happy to jump on a quick call at some point if that would be easier 😄

[gitbuda]

Ahaaa, @Elvino00, I've figured it out! The problem is build folder created inside the src folder. That won't work because CMake needs a top-level CMakeLists.txt file. Please create the build folder in the project root folder and then rerun everything, so

git clone https://github.com/memgraph/mgclient.git
cd mgclient
mkdir build && cd build
cmake ..
make

[Elvino00]

Ahaaa, @Elvino00, I've figured it out! The problem is build folder created inside the src folder. That won't work because CMake needs a top-level CMakeLists.txt file. Please create the build folder in the project root folder and then rerun everything, so

git clone https://github.com/memgraph/mgclient.git
cd mgclient
mkdir build && cd build
cmake ..
make

According to these three images, libraries should have been installed

[Elvino00]

Please @gitbuda I kindly ask you to specify to build in top directory in README.md file

[gitbuda]

#52 is this more clear?

[Elvino00]

#52 is this more clear?

Yes, but there's something I don't understand. When i Try to compile your example file "basic.c" with command gcc -o basic basic.c I get these errors:

Am I compiling this wrong?

[gitbuda]

The issue here is that the example needs to link the mgclient as a library. That can be done by the -l flag, e.g. gcc -o basic -lmgclient basic.c (not 100% sure because I haven't tested that, more details about linking -> https://www.rapidtables.com/code/linux/gcc/gcc-l.html)

On the other hand, all that work is already being done, you just have to enable tests (because examples are compiled if tests are active):

cd build
cmake -DBUILD_TESTING=ON ..
make

[Elvino00]

After make command, on the last rows of the terminal I get this error:

The issue here is that the example needs to link the mgclient as a library. That can be done by the -l flag, e.g. gcc -o basic -lmgclient basic.c (not 100% sure because I haven't tested that, more details about linking -> https://www.rapidtables.com/code/linux/gcc/gcc-l.html)

On the other hand, all that work is already being done, you just have to enable tests (because examples are compiled if tests are active):

cd build
cmake -DBUILD_TESTING=ON ..
make

Sorry for quoting your answer down here.