oops remove leftover comment in system-file-changes.yml#3680
Merged
peterbe merged 1 commit intoMar 30, 2021
Merged
Conversation
Contributor
Author
|
Great! Expected it to fail. A bit ugly to have a CI failure in the list of commits here in the GitHub UI. But c'est la vie. |
Contributor
|
You might need to make it a "Required" check (in branch policies) if you want non-admins to be blocked from merging |
Contributor
Author
Wouldn't that cause a weird catch-22 problem since you can't make workflows that might-not-even-run required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First real use of the system-file-changes workflow that makes sure any PR fails that contains too-sensitive changes.