Add Node.js data for PerformanceResourceTiming
#25010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyclouds2001
commented
Nov 11, 2024
Contributor
|
This pull request has merge conflicts that must be resolved before it can be merged. |
queengooborg
previously requested changes
Dec 17, 2024
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <[email protected]>
caugner
approved these changes
Jan 6, 2025
| "nodejs": [ | ||
| { | ||
| "version_added": "18.6.0", | ||
| "notes": "Since v18.2.0, the value can be returned by `toJSON()`, but can not accessed via property getter." |
Contributor
There was a problem hiding this comment.
Didn't double-check, but plausible based on nodejs/node#43593.
Comment on lines
+697
to
+705
| "nodejs": [ | ||
| { | ||
| "version_added": "18.2.0" | ||
| }, | ||
| { | ||
| "version_added": "16.17.0", | ||
| "version_removed": "17.0.0" | ||
| } | ||
| ], |
PerformanceResourceTimingPerformanceResourceTiming
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
most are taken from documentation:
https://nodejs.org/docs/latest/api/globals.html#performanceresourcetiming
https://nodejs.org/docs/latest/api/perf_hooks.html#class-performanceresourcetiming
but, note that
initiatorType,nextHopProtocol,responseStart,deliveryTypeandresponseStatusdoes not has its documentation, thus can not determine its version number via documentation (docs issue fired at nodejs/node#55793)most are implemented via nodejs/node#42725, in https://nodejs.org/zh-cn/blog/release/v16.17.0 and https://nodejs.org/zh-cn/blog/release/v18.2.0; also confirmed
nextHopProtocolandresponseStartis implemented here (hereinitiatorTypemay return fromtoJSON()method, but can not access directly)initiatorTypeis implemented via nodejs/node#43593, in https://nodejs.org/zh-cn/blog/release/v16.17.0 and https://nodejs.org/zh-cn/blog/release/v18.6.0deliveryTypeandresponseStatusis implemented via nodejs/node#51589, in https://nodejs.org/zh-cn/blog/release/v22.2.0Test results and supporting details
Related issues