fix(cli): import F_OK from fs.constants for Node ESM compatibility#3
Open
diwakar-s-maurya wants to merge 1 commit intomayfer:masterfrom
Open
fix(cli): import F_OK from fs.constants for Node ESM compatibility#3diwakar-s-maurya wants to merge 1 commit intomayfer:masterfrom
diwakar-s-maurya wants to merge 1 commit intomayfer:masterfrom
Conversation
`F_OK` is not available as a direct named ESM export from `node:fs`. Import it via `constants.F_OK` instead, which works on Node 18+.
|
Please approve this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
F_OKas a direct named ESM export fromnode:fs, causingbunx pg-hereandnpx pg-hereto crash withSyntaxError: The requested module 'node:fs' does not provide an export named 'F_OK'F_OKviafs.constantsinstead, which works on all Node versions from 18+Test
Ran
node scripts/cli-error-help.mjs 2>&1.