[bugfix] fix card update when added as payment method through Stripe API#189
Closed
michalpodlecki wants to merge 5 commits intomasterfrom
Closed
[bugfix] fix card update when added as payment method through Stripe API#189michalpodlecki wants to merge 5 commits intomasterfrom
michalpodlecki wants to merge 5 commits intomasterfrom
Conversation
|
📋 Open PR Cleanup Notice — @michalpodlecki Hi — we're running an org-wide cleanup of stale pull requests to keep our repos healthy and our review queues focused. This PR has been inactive for 1331 days. What's happeningWe're introducing an automated stale PR policy across
What you need to do before COB this Friday
What happens COB this FridayPRs that have been inactive for 37+ days will be automatically closed. No code is lost — branches are preserved and PRs can be reopened at any time. Exempt from cleanupPRs with any of these labels are skipped: 🤖 This is an automated message from the PR hygiene initiative. Questions? Reach out to the engineering ops team. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference link
https://chargify.atlassian.net/browse/PGT-2001
Why?
Some merchant encountered a problem with updating payment profiles in Stripe when credit card was created as a payment method rather than a card through the Stripe API. In result the 500 errors were raised.
What?
Both
conduitandactivemerchanthave been updated to be able to update payment methods as well, depending on customer's default payment method and default source.Conduit: https://github.com/chargify/conduit/pull/383
Chargify: https://github.com/chargify/chargify/pull/21396