Skip to content

[bugfix] fix card update when added as payment method through Stripe API#189

Closed
michalpodlecki wants to merge 5 commits intomasterfrom
PGT-2001-fix-card-update-when-added-as-payment-method
Closed

[bugfix] fix card update when added as payment method through Stripe API#189
michalpodlecki wants to merge 5 commits intomasterfrom
PGT-2001-fix-card-update-when-added-as-payment-method

Conversation

@michalpodlecki
Copy link
Copy Markdown

@michalpodlecki michalpodlecki commented Jul 23, 2022

Reference link

https://chargify.atlassian.net/browse/PGT-2001

Why?

Some merchant encountered a problem with updating payment profiles in Stripe when credit card was created as a payment method rather than a card through the Stripe API. In result the 500 errors were raised.

What?

Both conduit and activemerchant have been updated to be able to update payment methods as well, depending on customer's default payment method and default source.

Conduit: https://github.com/chargify/conduit/pull/383
Chargify: https://github.com/chargify/chargify/pull/21396

@MikeCocozza
Copy link
Copy Markdown

📋 Open PR Cleanup Notice@michalpodlecki

Hi — we're running an org-wide cleanup of stale pull requests to keep our repos healthy and our review queues focused.

This PR has been inactive for 1331 days.

What's happening

We're introducing an automated stale PR policy across maxio-com. Here's how it works:

Inactive for What happens
14+ days 👋 You'll get a nudge asking if the PR is still needed
30+ days ⚠️ Warning that auto-close is coming in 7 days
37+ days 🔒 PR is auto-closed (branch preserved, reopenable anytime)

What you need to do before COB this Friday

  • If this PR is still needed: push a commit, leave a comment, or add the keep-open label
  • If this PR is abandoned: close it yourself, or do nothing and it will be cleaned up automatically
  • If you're blocked: add the blocked label and it will be exempt from auto-close

What happens COB this Friday

PRs that have been inactive for 37+ days will be automatically closed. No code is lost — branches are preserved and PRs can be reopened at any time.

Exempt from cleanup

PRs with any of these labels are skipped: keep-open, do-not-close, blocked


🤖 This is an automated message from the PR hygiene initiative. Questions? Reach out to the engineering ops team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants