Draft
Conversation
This works to create gaps but for some reason after backfilling, we still see some gaps and not all messages appear.
Fixed Synapse to look for backfill points more loosely because of approximate `depth` comparison
7 tasks
1 task
MadLittleMods
commented
Nov 18, 2025
| // | ||
| // messagesResBody: from a `/messages?dir=b` request (these will be in reverse-chronological order) | ||
| // eventIDs: the list of event IDs in chronological order that we expect to see in the response | ||
| func assertMessagesInTimelineInOrder(t *testing.T, messagesResBody json.RawMessage, expectedEventIDs []string) { |
Collaborator
Author
There was a problem hiding this comment.
This assertion changed behavior in #816
(update to use assertEventsInOrder)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for MSC3871: Gappy timelines
Synapse PR: element-hq/synapse#18873
Dev notes
Document how to hook up Element to the resultant homeservers from Complement: #164
matrix-org/complement->ONBOARDING.md-> How do I hook up a Matrix client like Element to the homeservers spun up by Complement after a test runs?Todo
Pull Request Checklist