Use host-gateway to ensure servers can reach host#389
Merged
DMRobertson merged 3 commits intomainfrom Jun 14, 2022
Merged
Conversation
Member
Don't suppose there is an easy way to test the docker version? |
Contributor
Author
Either:
|
reivilibre
reviewed
Jun 7, 2022
Contributor
Author
Erik means: can we interrogate the docker version at runtime? It looks like this is exposed as |
kegsay
reviewed
Jun 13, 2022
Member
kegsay
left a comment
There was a problem hiding this comment.
Please add docs to the README to say you need Docker 20+, then LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes connectivity problems I was having when running complement. Oddly, noone else seems to have found this issue, and I don't really understand the underlying machinations.
I'm not sure if this will cause complement to fail in environments whose docker versions are older than 20.10.