Closed
Conversation
new inference module. Many Improvings on inference
7f9fa02 to
722d668
Compare
Move corresponding files in builtins under these submodules. Adjust lots of imports to include the new submodule
rocky
reviewed
May 1, 2021
mathics/builtin/inference.py
Outdated
| evaluation.message("Inconsistent assumptions") | ||
|
|
||
| if assumptions_list is None: | ||
| return remove_nots_when_unnecesary(pred, evaluation).evaluate(evaluation) |
rocky
reviewed
May 1, 2021
mathics/builtin/inference.py
Outdated
| assumption_rules.append(Rule(pat, symbol_value)) | ||
| # TODO: expand the pred and assumptions into an standard, | ||
| # atomized form, and then apply the rules... | ||
| print("assumptions:") |
Member
There was a problem hiding this comment.
Is this print and the one below supposed to be here?
new inference module. Many Improvings on inference
Member
|
@mmatera the code here doesn't look like it is ready for a PR. What's up? |
Contributor
Author
|
Superseded by #1337 |
1 similar comment
Contributor
Author
|
Superseded by #1337 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the part of ConditionalExpressions that involves advanced logical processing.