Conversation
chore: refactor normalize in dependency tree
The exports field previously only mapped the JS entry points, which
caused bundlers that enforce the Node.js package exports spec (esbuild,
Vite, webpack 5, Rollup) to block any sub-path import not explicitly
listed -- including the CSS and Sass files that are physically present
in the package.
Add wildcard export patterns for ./dist/css/*, ./sass/* and
./components/* so that imports like:
import '@materializecss/materialize/dist/css/materialize.min.css';
import '@materializecss/materialize/sass/materialize.scss';
import { Button } from '@materializecss/materialize/components/buttons/button.mjs';
resolve correctly in all spec-compliant bundlers.
Also add components/ to the files array so component sub-paths are
included in the published package.
The existing "style" and "sass" top-level fields are unaffected and
continue to work for bundlers that use those fields (e.g. webpack
mainFields resolution).
Closes #653
fix: expose CSS, Sass and component sub-paths in package.json exports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Screenshots (if appropriate) or codepen:
Types of changes
Checklist: