Catch utf8 decoding errors explicitly to fix py310 test failure #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, utf8 decode errors bubbled up into json.JSONDecodeError error handling, which triggered a bug in py310 specifically: - The failing test was test_http_multipart_invalid_utf8 (test graphql-python#17) - It sends invalid utf8 bytes (\xff\xfe) in the multipart response - aiohttp's part.text() raises a UnicodeDecodeError - The HTTP multipart transport wasn't catching UnicodeDecodeError, only json.JSONDecodeError - When pytest tried to format the uncaught underlying UnicodeDecodeError, the exceptiongroup package in py310 hit an internal bug: File "/home/runner/work/gql/gql/.tox/pypy3/lib/pypy3.10/site-packages/exceptiongroup/_formatting.py", line 329, in format_exception_only yield _format_final_exc_line(stype, self._str) File "/home/runner/work/gql/gql/.tox/pypy3/lib/pypy3.10/site-packages/exceptiongroup/_formatting.py", line 33, in _format_final_exc_line line = f"{etype}: {valuestr}\n" SystemError: unexpected internal exception (please report a bug): <CheckError object at 0x336b7e90> Catching the utf8 decoding error specifically does actually improve error handling anyway since it gives a more specific warning to the user imo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failing test in graphql-python#574 is
test_http_multipart_invalid_utf8.utf8 decoding errors bubbled up into a
JSONDecodeError, which triggered a bug under py310 specifically:\xff\xfe) in the multipart responsepart.text()raises aUnicodeDecodeErrorUnicodeDecodeError, onlyJSONDecodeErrorUnicodeDecodeError, the exceptiongroup package in py310 hit an internal bug:Catching the utf8 decoding error specifically does actually improve error handling anyway since it gives a more specific warning to the user imo.