feat: add undo/redo support for editing actions#1592
Open
ida-jemi wants to merge 1 commit into
Open
Conversation
- Add generic useUndoRedo hook with debounced history stack (max 25 entries) - Wire into useVideoEditor: push EditRecipe snapshots, expose undo/redo/canUndo/canRedo - Add Ctrl+Z / Ctrl+Shift+Z / Ctrl+Y keyboard shortcuts - Add Undo/Redo buttons next to Reset All Settings - Update KeyboardShortcutsPanel with new shortcuts - Add unit tests for useUndoRedo Closes magic-peach#1591
|
@ida-jemi is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
✅ PR Format Check Passed — @ida-jemiBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Contributor
👋 Thanks for your PR, @ida-jemi!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds undo/redo support for editing actions, as requested in the issue.
useUndoRedohook (src/hooks/useUndoRedo.ts) , a generic history stack withpush,undo,redo,canUndo,canRedo, andreset. History is capped at 25 entries.useVideoEditor: everyrecipechange is debounced ~400ms before being committed to history, so dragging sliders (brightness/contrast/trim) creates one history entry per gesture instead of one per pixel of drag.useKeyboardShortcuts.ts.VideoEditor.tsx, disabled appropriately at either end of the stack.Scope note:
file,musicFile, andoverlayFile(actualFileobjects) are intentionally not part of the undo stack — onlyEditRecipe-level settings (trim, rotate, framing, speed, color, overlay position/size/opacity, format, text overlays) are tracked, matching the scope described in the issue.Related Issue
Closes #1591
Type of Contribution
Participant Info
Screen Recording
Screen.Recording.2026-06-20.185121.mp4
Checklist
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in