Fix MacosPulldownMenuItem.onTap doesn't open alert dialog#520
Merged
GroovinChip merged 2 commits intomacosui:devfrom Oct 5, 2024
TahaTesser:fix_MacosPulldownMenuItem_onTap
Merged
Fix MacosPulldownMenuItem.onTap doesn't open alert dialog#520GroovinChip merged 2 commits intomacosui:devfrom TahaTesser:fix_MacosPulldownMenuItem_onTap
MacosPulldownMenuItem.onTap doesn't open alert dialog#520GroovinChip merged 2 commits intomacosui:devfrom
TahaTesser:fix_MacosPulldownMenuItem_onTap
Conversation
GroovinChip
requested changes
Oct 3, 2024
Collaborator
GroovinChip
left a comment
There was a problem hiding this comment.
Thanks for the PR @TahaTesser !!! Just one small change request and then we are good to go
lib/src/buttons/pulldown_button.dart
Outdated
| widget.route.items[widget.itemIndex].item!; | ||
| if (menuEntity is MacosPulldownMenuItem) { | ||
| menuEntity.onTap?.call(); | ||
| Navigator.pop(context); |
Collaborator
There was a problem hiding this comment.
Can we make this .of(context).pop() please?
Collaborator
|
Just gonna run the checks manually since you're a first time contributor |
Collaborator
|
Looks like we've got some failing tests |
Contributor
Author
For some reason test passes locally with FlutterLogo but not in the CI so i just replaced it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes MacosPulldownMenuItem onTap doesnt call showMacosAlertDialog
Code sample
expand to view the code sample
Preview
Pre-launch Checklist
CHANGELOG.mdwith my changes