Support abstract generic field and create tests #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces IIntrinsicTypePolicy, ITypeCandiateProvider, and ITypeCompatibilityPolicy interfaces with default implementations for type filtering and compatibility checks. Adds Unity 2023.2+ specific implementations to support generic variance in type compatibility and candidate discovery. These abstractions improve extensibility and support for advanced type scenarios in SerializeReferenceExtensions.
Replaces TypeSearch with TypeCandiateService and TypeSearchService for improved modularity and extensibility. Updates SubclassSelectorDrawer to use the new service. Removes obsolete TypeSearch and related files.
Moved the UNITY_2023_2_OR_NEWER preprocessor directive to wrap the entire file instead of just the class, ensuring the file is only included for compatible Unity versions.
Moved the test assembly definition to an Editor folder, renamed it to MackySoft.SerializeReferenceExtensions.Tests.Editor, and updated its root namespace. Added a placeholder TypeCandidateTestTypes.cs script for future Editor tests.
Added checks to filter out primitive and enum types in the intrinsic type policy, ensuring only appropriate types are considered for serialization.
Introduces new unit tests for DefaultIntrinsicTypePolicy and TypeCandidateService, covering intrinsic type policy, base type inclusion, generic variance (Unity 2023.2+), and non-generic candidate filtering. Also expands TypeCandidateTestTypes with various test types to support these scenarios.
Moved type search-related interfaces and implementations into a new Editor/TypeSearch folder for better organization. Updated file paths and separated interface definitions from their default implementations.
Replaces UNITY_LICENSE_2020 with UNITY_LICENSE, adds UNITY_EMAIL and UNITY_PASSWORD environment variables, and sets unityVersion to 2021.3.45f2 for the build job.
Changed Unity version from 2021.3.29f1 to 2021.3.45f2 in both package and release workflows. Updated UNITY_LICENSE secret reference in package workflow to use the generic UNITY_LICENSE variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes made