feat: capture page_url in events#1276
Conversation
PR SummaryMedium Risk Overview
Tests assert capture at event creation, Reviewed by Cursor Bugbot for commit 8f5a180. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8f5a180. Configure here.
| "@babel/preset-typescript": "^7.6.0", | ||
| "@mparticle/data-planning-models": "^0.1.0", | ||
| "@mparticle/event-models": "^1.1.9", | ||
| "@mparticle/event-models": "^1.3.0", |
There was a problem hiding this comment.
I see you're importing event-models but they don't look like they're being used.



Background
page_url, so we have no visibility into where on a site an event was fired.page_urlfrom the client, and is related to PR1 and PR2— the mPServer PRs that handles the new field on the backend, propagating, sanitizing, and gating it for safety in case the URL contains PII.What Has Changed
@mparticle/event-modelsto^1.3.0(addspage_url?: stringonCommonEventData).PageUrl?: stringto the internalSDKEventinterface.createEventObjectpath and on thecreateBackgroundASTEventpath. External callers using thetoEventAPIObjectescape hatch own the full event shape and are not modifiedconvertBaseEventDatamapssdkEvent.PageUrl→page_urlin the events-API payload.PageUrlis optional.Screenshots/Video
Checklist
Additional Notes
Reference Issue (For employees only. Ignore if you are an outside contributor)