Skip to content

ci: update action versions#132

Merged
rmi22186 merged 3 commits into
masterfrom
ci/fix
Feb 13, 2025
Merged

ci: update action versions#132
rmi22186 merged 3 commits into
masterfrom
ci/fix

Conversation

@rmi22186
Copy link
Copy Markdown
Member

Summary

There was a failing workflow run that requires updating the action versions

Comment thread .github/workflows/pull-request.yml Outdated
uses: actions/setup-node@v3
with:
node-version: 12.x
node-version: 16.x
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should replace this entire file with this reusable workflow file, or at the very least, the reusable PR workflow.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was thinking that. but i also saw the lerna step and i didn't want to mess with that. we can discuss on our zoom shortly

@alexs-mparticle alexs-mparticle self-requested a review February 13, 2025 15:06
@rmi22186 rmi22186 merged commit da97c6b into master Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants