fix(testing-environment): should have Node on global

[colinaaa]

@testing-library/jest-dom has published a new version v6.9.0, which would reference the Node from global. See: testing-library/jest-dom#702

Summary by CodeRabbit

• New Features

  • Added a test script to run Vitest in the testing environment.

• Bug Fixes

  • Fixed a “Node is not defined” error in Vitest setup, improving test stability.

• Chores

  • Updated @testing-library/jest-dom to v6.9.0 across packages and templates.
  • Added patch dependencies: @lynx-js/react and @lynx-js/testing-environment.

• Tests

  • Improved test environment configuration for compatibility with latest testing libraries.

Checklist

• Tests updated (or not required).
• Documentation updated (or not required).
• Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

[changeset-bot]

🦋 Changeset detected

Latest commit: ca4401c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@lynx-js/react	Patch
@lynx-js/testing-environment	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

📝 Walkthrough

Walkthrough

Bumps @testing-library/jest-dom to v6.9.0 across packages and templates, adds a Vitest test script in the testing-environment package, and updates the Vitest environment to assign and later delete global.Node from the JSDOM instance to fix a ReferenceError. Includes a changeset documenting these updates.

Changes

Cohort / File(s)	Summary
Dependency bumps (Jest DOM) packages/react/testing-library/package.json, packages/testing-library/examples/basic/package.json, packages/testing-library/testing-environment/package.json, packages/rspeedy/create-rspeedy/template-react-vitest-rltl-*/package.json	Update devDependency @testing-library/jest-dom from ^6.8.0 to ^6.9.0.
Vitest environment (Node global exposure) packages/testing-library/testing-environment/src/env/vitest/index.ts	Import Environment type; during setup assign global.Node = lynxTestingEnv.jsdom.window.Node; during teardown delete global.Node; object now typed with } satisfies Environment;.
Testing env scripts packages/testing-library/testing-environment/package.json	Add "test": "vitest" script.
Changeset .changeset/hot-gifts-carry.md	Add changeset noting the dependency bumps and the Node global fix.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• feat: allow passing jsdom to new LynxTestingEnv #1422 — Touches the testing-environment Vitest setup and JSDOM/global handling; closely related to the global.Node injection/teardown here.

Suggested reviewers

• hzy
• upupming

Poem

I twitch my whiskers in testy delight,
A Node appears in the global night! 🌙
Jest-DOM hops up to six point nine,
Vitest runs steady, tests align.
I nibble a carrot and ship the fix—hop! 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title succinctly describes the primary change of adding Node to the global scope in the testing environment, aligning with the conventional commit style and reflecting the main fix implemented in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

[codspeed-hq]

CodSpeed Performance Report

Merging #1850 will degrade performances by 10.41%

_{Comparing colinaaa:colin/0930/jest-dom (a9cd5ef) with main (8dd1ecb)}

Summary

⚡ 1 improvement
❌ 2 regressions
✅ 50 untouched
⏩ 3 skipped¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
❌	transform 1000 view elements	40 ms	44.6 ms	-10.41%
⚡	basic-performance-image-100	10.4 ms	9.8 ms	+6.17%
❌	basic-performance-scroll-view-100	9.2 ms	9.7 ms	-5.2%

Footnotes

1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[relativeci]

React Example

#5682 Bundle Size — 237.56KiB (0%).

a9cd5ef(current) vs 8dd1ecb main#5673(baseline)

Bundle metrics  no changes

	Current #5682	Baseline #5673
Initial JS	0B	0B
Initial CSS	0B	0B
Cache Invalidation	0%	0%
Chunks	0	0
Assets	4	4
Modules	166	166
Duplicate Modules	68	68
Duplicate Code	46.82%	46.82%
Packages	2	2
Duplicate Packages	0	0

Bundle size by type  no changes

	Current #5682	Baseline #5673
IMG	145.76KiB	145.76KiB
Other	91.8KiB	91.8KiB

Bundle analysis report Branch colinaaa:colin/0930/jest-dom Project dashboard

---

^{Generated by RelativeCI Documentation Report issue}

[relativeci]

Web Explorer

#5677 Bundle Size — 365.13KiB (0%).

a9cd5ef(current) vs 8dd1ecb main#5668(baseline)

Bundle metrics   1 change

	Current #5677	Baseline #5668
Initial JS	145.05KiB	145.05KiB
Initial CSS	32KiB	32KiB
Cache Invalidation	0%	0%
Chunks	8	8
Assets	8	8
Modules	219(-0.45%)	220
Duplicate Modules	16	16
Duplicate Code	3.36%	3.36%
Packages	4	4
Duplicate Packages	0	0

Bundle size by type  no changes

	Current #5677	Baseline #5668
JS	239.33KiB	239.33KiB
Other	93.8KiB	93.8KiB
CSS	32KiB	32KiB

Bundle analysis report Branch colinaaa:colin/0930/jest-dom Project dashboard

---

^{Generated by RelativeCI Documentation Report issue}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b3b5fe1 and a9cd5ef.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (7)

• .changeset/hot-gifts-carry.md (1 hunks)
• packages/react/testing-library/package.json (1 hunks)
• packages/rspeedy/create-rspeedy/template-react-vitest-rltl-js/package.json (1 hunks)
• packages/rspeedy/create-rspeedy/template-react-vitest-rltl-ts/package.json (1 hunks)
• packages/testing-library/examples/basic/package.json (1 hunks)
• packages/testing-library/testing-environment/package.json (1 hunks)
• packages/testing-library/testing-environment/src/env/vitest/index.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

.changeset/*.md

📄 CodeRabbit inference engine (AGENTS.md)

For contributions, generate and commit a Changeset describing your changes

Files:

• .changeset/hot-gifts-carry.md

🧠 Learnings (1)

📚 Learning: 2025-08-11T05:59:28.530Z

Learnt from: upupming
PR: lynx-family/lynx-stack#1305
File: packages/react/testing-library/src/plugins/vitest.ts:4-6
Timestamp: 2025-08-11T05:59:28.530Z
Learning: In the lynx-family/lynx-stack repository, the `packages/react/testing-library` package does not have `vite` as a direct dependency. It relies on `vitest` being available from the monorepo root and accesses Vite types through re-exports from `vitest/node`. Direct imports from `vite` should not be suggested for this package.

Applied to files:

• packages/react/testing-library/package.json

🔇 Additional comments (7)

packages/testing-library/testing-environment/package.json (2)

53-53: LGTM: Test script addition.

Adding a test script is appropriate for a testing environment package and enables direct test execution.

---

56-56: LGTM: Dependency upgrade to jest-dom v6.9.0.

The version bump aligns with the PR's objective to support @testing-library/jest-dom v6.9.0, which requires the Node global exposure fix.

.changeset/hot-gifts-carry.md (1)

1-9: LGTM: Well-documented changeset.

The changeset correctly documents the fix with appropriate patch version bumps for both affected packages and includes helpful references to the upstream jest-dom changes.

packages/testing-library/examples/basic/package.json (1)

18-18: LGTM: Consistent dependency upgrade.

The version bump keeps the example package in sync with the testing environment upgrade.

packages/react/testing-library/package.json (1)

16-16: LGTM: Completes coordinated dependency upgrade.

The version bump aligns with the other packages in this PR, completing the coordinated upgrade to jest-dom v6.9.0 across the testing stack.

packages/rspeedy/create-rspeedy/template-react-vitest-rltl-js/package.json (1)

19-19: LGTM! Version bump aligns with upstream changes.

The update to @testing-library/jest-dom v6.9.0 is necessary to support the library's new global Node reference, which is addressed by the Vitest environment changes mentioned in the PR.

packages/rspeedy/create-rspeedy/template-react-vitest-rltl-ts/package.json (1)

21-21: LGTM! Consistent version bump.

The @testing-library/jest-dom update to v6.9.0 matches the change in the JavaScript template and supports the new global Node requirement.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/testing-library/testing-environment/src/env/vitest/index.ts (1)

16-16: LGTM: Correctly exposes Node to global scope.

The assignment properly addresses the ReferenceError by exposing the DOM Node constructor from jsdom to the global scope, which @testing-library/jest-dom v6.9.0 requires. The cleanup in teardown (line 22) ensures no leakage between test runs.

Optional: Consider preserving pre-existing global.Node.

If global.Node already exists before setup (unlikely in typical test environments), this assignment will overwrite it without restoration. Consider storing and restoring any pre-existing value if you want to be defensive.

Apply this diff to preserve and restore any pre-existing global.Node:

  async setup(global) {
+   const originalNode = global.Node;
    const fakeGlobal: {
      jsdom?: any;
    } = {};
    await builtinEnvironments.jsdom.setup(fakeGlobal, {});

    const lynxTestingEnv = new LynxTestingEnv(fakeGlobal.jsdom as JSDOM);
    global.lynxTestingEnv = lynxTestingEnv;
    global.Node = lynxTestingEnv.jsdom.window.Node;

    return {
      teardown(global) {
        delete global.lynxTestingEnv;
        delete global.jsdom;
-       delete global.Node;
+       if (originalNode !== undefined) {
+         global.Node = originalNode;
+       } else {
+         delete global.Node;
+       }
      },
    };
  },

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a9cd5ef and ca4401c.

📒 Files selected for processing (1)

• packages/testing-library/testing-environment/src/env/vitest/index.ts (2 hunks)

🔇 Additional comments (3)

packages/testing-library/testing-environment/src/env/vitest/index.ts (3)

1-1: LGTM: Environment type import is correct.

The addition of the Environment type import is necessary for the type annotation on line 26 and follows idiomatic TypeScript practices.

---

22-22: LGTM: Cleanup resolves past review concern.

The deletion of global.Node in teardown correctly prevents leaking the Node constructor between test runs, addressing the concern raised in the previous review.

---

26-26: LGTM: Proper use of TypeScript's satisfies operator.

The satisfies Environment annotation provides compile-time type safety, ensuring the environment object conforms to Vitest's Environment interface without widening the type. This is the recommended pattern for type-checking object literals.