Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
klemen1999
approved these changes
Mar 19, 2026
Test Results 6 files 6 suites 24m 33s ⏱️ Results for commit 77dd21a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
onnxsim release 0.6.0 on the 25th of February and 0.6.2 on the 26th of February (https://pypi.org/project/onnxsim/#history). In a recent PR, the onnxsim version resolves to 0.6.2 and the workflow tests fail on macOS only (example).
I was able to fix this in #209 and confirm that this fix passes the workflow install and tests, but since #209 is a low priority PR I made this PR with solely this fix. This is because other repositories' BOM tests that include the tools
repofail because of this new onnxsim version (example).As for the reason behind this regression, it seems that recent
onnxsimreleases change the macOS wheel artifacts which changes how the package is installed in our workflows (just found: The macOS wheel tag changed from macosx_10_15_universal2 in 0.5.0 to macosx_11_0_arm64 in 0.6.1 and 0.6.2)Specification
Dependencies & Potential Impact
Deployment Plan
Testing & Validation