This repository was archived by the owner on Apr 3, 2024. It is now read-only.
Open
Conversation
…s just one problem, give me the whole response back so I can parse it myself
Owner
|
Hi Lars Thanks for this. Whilst I appreciate the pull request, these changes really need some tests before I can merge them. Thanks |
Author
|
Yeah yeah yeah, always the tests ... ;) Had a problem to solve, so just solved it. I have several other things, I might have to add - concat and unicode being the first two that come to mind. Will keep the thing about tests in mind :) //Lars |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've changed the way error handling works so if you send multiple messages at once, we won't raise an exception just because one of those messages failed. You'd really want to be able to parse the response and deal with them indidivually.
Plus, when the error message ends with a colon, the error parsing returned empty code and messages.
Here's the error I was getting back:
ERR: 105, Invalid Destination Address To:
ERR: 105, Invalid Destination Address To:
ERR: 105, Invalid Destination Address To:
(many more like these)
//Lars