chore: add more info to log in SAML authn APIs #8050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/core/src/routes/saml-application/anonymous.ts | 📈 +339 Bytes |
simeng-li
approved these changes
Dec 8, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds additional logging information to SAML authentication API endpoints to improve observability and debugging capabilities. However, the logging additions expose security-sensitive information that should not be stored in plain text logs.
Key changes:
- Added logging for
signInUrl,createSession, andinsertSamlAppSessionobjects in two SAML authentication handlers - Fixed a bug where the entire
insertSamlAppSessionobject was being logged instead of just theidin the cookie log entry
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add more info to log in SAML authn APIs
Testing
N/A
Checklist
.changeset