-
Notifications
You must be signed in to change notification settings - Fork 139
Golden Honey Badger Implementation #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
c65bca4
add: honey badger without bg in images directory
AndreaDiazCorreia ef3e722
add: function in utils for honey badger
AndreaDiazCorreia 9c6562e
add: locales for the honeybadger message
AndreaDiazCorreia 1af0da2
feat: honey badger to take a buy
AndreaDiazCorreia ebc13f9
fix: message
AndreaDiazCorreia 77bc125
Update bot/messages.ts
AndreaDiazCorreia fa1eade
fix: cancel message
AndreaDiazCorreia 709874f
fix: fee in only honeybadger
AndreaDiazCorreia 0be4bbf
fix: honeybadger fee
AndreaDiazCorreia 2332d1a
fix: zero fees
AndreaDiazCorreia 468e462
fix: fees
AndreaDiazCorreia c5d1d66
fix: fees in honey badger
AndreaDiazCorreia aa927a4
remove: unused code about honey badger
AndreaDiazCorreia 1774be7
Merge branch 'main' into feat/honeybadger
AndreaDiazCorreia 5ce2e1b
fix: fix the fee when someone take a buy order (finally)
AndreaDiazCorreia 1b05aae
remove unnecessary logs
AndreaDiazCorreia 6cdc689
remove unnecessary comments
AndreaDiazCorreia b099563
fix: double calculation
AndreaDiazCorreia eccbf1b
fix: double message
AndreaDiazCorreia b9dbbd8
delete unnecessary comments
AndreaDiazCorreia 516e5b5
change: image of honeybadger
AndreaDiazCorreia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Improvements to currency symbol handling and Golden Honey Badger messaging.
The function has been enhanced with a more structured approach to currency symbol extraction and includes the Golden Honey Badger messaging when applicable.
Consider using optional chaining for better null safety:
const currency = getCurrency(fiatCode); const currencySymbol = - (currency !== null && currency.symbol_native) + currency?.symbol_native ? currency.symbol_native : fiatCode;📝 Committable suggestion
🧰 Tools
🪛 Biome (1.9.4)
[error] 382-382: Change to an optional chain.
Unsafe fix: Change to an optional chain.
(lint/complexity/useOptionalChain)
🤖 Prompt for AI Agents (early access)