Skip to content

[MLIR][Transform] Safely erase transform ops by collecting first #172016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
milos1397 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[MLIR][Transform] Safely erase transform ops by collecting first #172016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions mlir/test/Dialect/Transform/transform-dialect-erase-schedule.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// RUN: mlir-opt %s -test-transform-dialect-erase-schedule | FileCheck %s

module attributes {transform.with_named_sequence} {
func.func @transform_example(%arg0: !transform.any_op) {
%transform_copy = transform.structured.match ops{["linalg.copy"]} in %arg0 : (!transform.any_op) -> !transform.any_op
transform.nvgpu.rewrite_copy_as_tma %transform_copy : (!transform.any_op) -> ()
transform.yield
}
}

// CHECK-LABEL: module attributes {transform.with_named_sequence} {
// CHECK-NEXT: func.func @transform_example(%arg0: !transform.any_op) {
// CHECK-NEXT: transform.yield
// CHECK-NEXT: }
// CHECK-NEXT: }
7 changes: 6 additions & 1 deletion mlir/test/lib/Dialect/Transform/TestTransformDialectInterpreter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,18 @@ struct TestTransformDialectEraseSchedulePass
}

void runOnOperation() override {
SmallVector<Operation *> opsToDelete;
getOperation()->walk<WalkOrder::PreOrder>([&](Operation *nestedOp) {
if (isa<transform::TransformOpInterface>(nestedOp)) {
nestedOp->erase();
opsToDelete.push_back(nestedOp);
return WalkResult::skip();
}
return WalkResult::advance();
});
for (Operation *op : llvm::reverse(opsToDelete)) {
// erase the operation
op->erase();
}
}
};
} // namespace
Expand Down