Skip to content

fix for truncate broadcast ENOENT - #594

Merged
adammoody merged 1 commit into
llnl:devfrom
MichaelBrim:truncate-ENOENT-fix
Dec 18, 2020
Merged

fix for truncate broadcast ENOENT#594
adammoody merged 1 commit into
llnl:devfrom
MichaelBrim:truncate-ENOENT-fix

Conversation

@MichaelBrim

Copy link
Copy Markdown
Collaborator

Description

Adam's recent PR #587 adds a call to unifyfs_fid_truncate() when a file is created with O_TRUNC. This is correct behavior, but the change introduced new server error messages when running our examples that use testutil for N-1 shared files. The errors show up when processing the truncate broadcast rpc at non-owner servers where the inode has not yet been created, since only client rank 0 does the create.

The fix is to not treat the missing inode as an error on non-owner servers.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Testing (addition of new tests or update to current tests)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the UnifyFS code style requirements.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commit messages are properly formatted.

@MichaelBrim
MichaelBrim marked this pull request as ready for review December 18, 2020 16:27
@MichaelBrim MichaelBrim removed the WIP label Dec 18, 2020

@adammoody adammoody left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, @MichaelBrim .

@adammoody
adammoody merged commit 1f7c9e1 into llnl:dev Dec 18, 2020
@adammoody

Copy link
Copy Markdown
Collaborator

@CamStan , I optimistically merged this, but it'd be good to run your test once more to verify that truncate ENOENT message is gone.

@CamStan

CamStan commented Dec 21, 2020

Copy link
Copy Markdown
Member

Verified. The truncate ENOENT message I was seeing is gone with this fix.

@MichaelBrim
MichaelBrim deleted the truncate-ENOENT-fix branch January 4, 2021 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants