fix(docs): #1 human-readable keychain metadata + field-name translation design note#25
Merged
Conversation
…d-name translation design note Closes #1. Replaces `ak-keychain-meta` in docs/manual-test-stage4.md with a sed-based pretty-printer that rewrites Apple's FourCharCode attribute names (svce, acct, cdat, mdat, ...) to their English equivalents (service, account, created, modified, ...). Keeps `ak-keychain-meta-raw` as an escape hatch. Adds docs/field-name-translation.md capturing the general principle — "translate at the layer closest to the human" — plus the Layer-1 translation table and guidance for future surfaces. No code changes. No test impact. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Author
|
Codex review (via gstack VerdictThe patch only adds documentation and a shell helper used in the manual test guide, and the changes appear internally consistent. I did not find a discrete issue that would break existing code, tests, or the documented Stage 4 workflow. — codex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
ak-keychain-metaindocs/manual-test-stage4.mdwith a client-side sed pretty-printer that translates Apple's FourCharCode attribute names to English. Addsdocs/field-name-translation.mdwith the general principle and Layer-1 mapping.What changed
docs/manual-test-stage4.md—ak-keychain-metaswapped for a sed-based pretty-printer;ak-keychain-meta-rawadded as escape hatch.docs/field-name-translation.md(new) — design note: translate at the layer closest to the human.Test plan
No code or test impact. Verification is visual:
ak-keychain-metaagainst a live keychain entry; confirm output usesservice/account/created/modifiedlabels.ak-keychain-meta-raw; confirm original Apple output (withsvce/acct/cdat/...) still available for troubleshooting.Issue
Closes #1.
🤖 Generated with Claude Code
Codex review (2026-04-14): ✅ Approved — no actionable findings. See the codex comment above for details.