SyntaxWarning: "is" with a literal. Did you mean "=="?

[thrubovc]

Expected Behavior

docker image starts up without problems

Current Behavior

when I start the container, in the logs I see a traceback (including a couple of preceding lines for reference)

letsencrypt_proxy    | NOTICE: Staging is active
letsencrypt_proxy    | 2048 bit DH parameters present
letsencrypt_proxy    | No subdomains defined
letsencrypt_proxy    | E-mail address entered: tomas.hrubovcak@gmail.com
letsencrypt_proxy    | http validation is selected
letsencrypt_proxy    | Different validation parameters entered than what was used before. Revoking and deleting existing certificate, and an updated one will be created
letsencrypt_proxy    | Generating new certificate
letsencrypt_proxy    | /usr/lib/python3.8/site-packages/jmespath/visitor.py:32: SyntaxWarning: "is" with a literal. Did you mean "=="?
letsencrypt_proxy    |   if x is 0 or x is 1:
letsencrypt_proxy    | /usr/lib/python3.8/site-packages/jmespath/visitor.py:32: SyntaxWarning: "is" with a literal. Did you mean "=="?
letsencrypt_proxy    |   if x is 0 or x is 1:
letsencrypt_proxy    | /usr/lib/python3.8/site-packages/jmespath/visitor.py:34: SyntaxWarning: "is" with a literal. Did you mean "=="?
letsencrypt_proxy    |   elif y is 0 or y is 1:
letsencrypt_proxy    | /usr/lib/python3.8/site-packages/jmespath/visitor.py:34: SyntaxWarning: "is" with a literal. Did you mean "=="?
letsencrypt_proxy    |   elif y is 0 or y is 1:
letsencrypt_proxy    | /usr/lib/python3.8/site-packages/jmespath/visitor.py:260: SyntaxWarning: "is" with a literal. Did you mean "=="?
letsencrypt_proxy    |   if original_result is 0:
letsencrypt_proxy    | /usr/lib/python3.8/site-packages/digitalocean/LoadBalancer.py:19: SyntaxWarning: "is" with a literal. Did you mean "=="?
letsencrypt_proxy    |   if type is 'cookies':
letsencrypt_proxy    | /usr/lib/python3.8/site-packages/CloudFlare/cloudflare.py:65: SyntaxWarning: "is" with a literal. Did you mean "=="?
letsencrypt_proxy    |   if self.email is '' or self.token is '':
letsencrypt_proxy    | /usr/lib/python3.8/site-packages/CloudFlare/cloudflare.py:65: SyntaxWarning: "is" with a literal. Did you mean "=="?
letsencrypt_proxy    |   if self.email is '' or self.token is '':
letsencrypt_proxy    | /usr/lib/python3.8/site-packages/CloudFlare/cloudflare.py:89: SyntaxWarning: "is" with a literal. Did you mean "=="?
letsencrypt_proxy    |   if self.email is '' or self.token is '':
letsencrypt_proxy    | /usr/lib/python3.8/site-packages/CloudFlare/cloudflare.py:89: SyntaxWarning: "is" with a literal. Did you mean "=="?
letsencrypt_proxy    |   if self.email is '' or self.token is '':
letsencrypt_proxy    | /usr/lib/python3.8/site-packages/CloudFlare/cloudflare.py:113: SyntaxWarning: "is" with a literal. Did you mean "=="?
letsencrypt_proxy    |   if self.certtoken is '' or self.certtoken is None:
letsencrypt_proxy    | Saving debug log to /var/log/letsencrypt/letsencrypt.log

important note: this error doesn't make the container fail, it finishes up fine and the proxy server works.
EDIT: this error only appears upon the first run of the container, not after a rerun.

Steps to Reproduce

docker-compose up

Environment

OS Raspbian Buster (kernel 4.19.93-v7l+)
CPU architecture: arm32
How docker service was installed: apt install from the official repo https://download.docker.com/linux/raspbian/dists/buster/stable/

Command used to create docker container (run/create/compose/screenshot)

using docker-compose. contents below:

version: "3"

services:
  letsencrypt_proxy:
    container_name: letsencrypt_proxy
    image: linuxserver/letsencrypt
    cap_add:
      - NET_ADMIN
    environment:
      - PUID=1000
      - PGID=1000
      - TZ=Europe/Budapest
      - URL=example.com
      - STAGING=true
      - VALIDATION=http
    ports:
      - '80:80'
      - '443:443'
    volumes:
      - './letsencrypt:/config'
    restart: unless-stopped

Docker logs

Creating letsencrypt_proxy ... done
Attaching to letsencrypt_proxy
letsencrypt_proxy    | [s6-init] making user provided files available at /var/run/s6/etc...exited 0.
letsencrypt_proxy    | [s6-init] ensuring user provided files have correct perms...exited 0.
letsencrypt_proxy    | [fix-attrs.d] applying ownership & permissions fixes...
letsencrypt_proxy    | [fix-attrs.d] done.
letsencrypt_proxy    | [cont-init.d] executing container initialization scripts...
letsencrypt_proxy    | [cont-init.d] 01-envfile: executing... 
letsencrypt_proxy    | [cont-init.d] 01-envfile: exited 0.
letsencrypt_proxy    | [cont-init.d] 10-adduser: executing... 
letsencrypt_proxy    | 
letsencrypt_proxy    | -------------------------------------
letsencrypt_proxy    |           _         ()
letsencrypt_proxy    |          | |  ___   _    __
letsencrypt_proxy    |          | | / __| | |  /  \ 
letsencrypt_proxy    |          | | \__ \ | | | () |
letsencrypt_proxy    |          |_| |___/ |_|  \__/
letsencrypt_proxy    | 
letsencrypt_proxy    | 
letsencrypt_proxy    | Brought to you by linuxserver.io
letsencrypt_proxy    | We gratefully accept donations at:
letsencrypt_proxy    | https://www.linuxserver.io/donate/
letsencrypt_proxy    | -------------------------------------
letsencrypt_proxy    | GID/UID
letsencrypt_proxy    | -------------------------------------
letsencrypt_proxy    | 
letsencrypt_proxy    | User uid:    1000
letsencrypt_proxy    | User gid:    1000
letsencrypt_proxy    | -------------------------------------
letsencrypt_proxy    | 
letsencrypt_proxy    | [cont-init.d] 10-adduser: exited 0.
letsencrypt_proxy    | [cont-init.d] 20-config: executing... 
letsencrypt_proxy    | [cont-init.d] 20-config: exited 0.
letsencrypt_proxy    | [cont-init.d] 30-keygen: executing... 
letsencrypt_proxy    | using keys found in /config/keys
letsencrypt_proxy    | [cont-init.d] 30-keygen: exited 0.
letsencrypt_proxy    | [cont-init.d] 50-config: executing... 
letsencrypt_proxy    | Variables set:
letsencrypt_proxy    | PUID=1000
letsencrypt_proxy    | PGID=1000
letsencrypt_proxy    | TZ=Europe/Budapest
letsencrypt_proxy    | URL=example.com
letsencrypt_proxy    | SUBDOMAINS=
letsencrypt_proxy    | EXTRA_DOMAINS=
letsencrypt_proxy    | ONLY_SUBDOMAINS=false
letsencrypt_proxy    | DHLEVEL=2048
letsencrypt_proxy    | VALIDATION=http
letsencrypt_proxy    | DNSPLUGIN=
letsencrypt_proxy    | STAGING=true
letsencrypt_proxy    | 
letsencrypt_proxy    | NOTICE: Staging is active
letsencrypt_proxy    | 2048 bit DH parameters present
letsencrypt_proxy    | No subdomains defined
letsencrypt_proxy    | http validation is selected
letsencrypt_proxy    | Different validation parameters entered than what was used before. Revoking and deleting existing certificate, and an updated one will be created
letsencrypt_proxy    | Generating new certificate
letsencrypt_proxy    | /usr/lib/python3.8/site-packages/jmespath/visitor.py:32: SyntaxWarning: "is" with a literal. Did you mean "=="?
letsencrypt_proxy    |   if x is 0 or x is 1:
letsencrypt_proxy    | /usr/lib/python3.8/site-packages/jmespath/visitor.py:32: SyntaxWarning: "is" with a literal. Did you mean "=="?
letsencrypt_proxy    |   if x is 0 or x is 1:
letsencrypt_proxy    | /usr/lib/python3.8/site-packages/jmespath/visitor.py:34: SyntaxWarning: "is" with a literal. Did you mean "=="?
letsencrypt_proxy    |   elif y is 0 or y is 1:
letsencrypt_proxy    | /usr/lib/python3.8/site-packages/jmespath/visitor.py:34: SyntaxWarning: "is" with a literal. Did you mean "=="?
letsencrypt_proxy    |   elif y is 0 or y is 1:
letsencrypt_proxy    | /usr/lib/python3.8/site-packages/jmespath/visitor.py:260: SyntaxWarning: "is" with a literal. Did you mean "=="?
letsencrypt_proxy    |   if original_result is 0:
letsencrypt_proxy    | /usr/lib/python3.8/site-packages/digitalocean/LoadBalancer.py:19: SyntaxWarning: "is" with a literal. Did you mean "=="?
letsencrypt_proxy    |   if type is 'cookies':
letsencrypt_proxy    | /usr/lib/python3.8/site-packages/CloudFlare/cloudflare.py:65: SyntaxWarning: "is" with a literal. Did you mean "=="?
letsencrypt_proxy    |   if self.email is '' or self.token is '':
letsencrypt_proxy    | /usr/lib/python3.8/site-packages/CloudFlare/cloudflare.py:65: SyntaxWarning: "is" with a literal. Did you mean "=="?
letsencrypt_proxy    |   if self.email is '' or self.token is '':
letsencrypt_proxy    | /usr/lib/python3.8/site-packages/CloudFlare/cloudflare.py:89: SyntaxWarning: "is" with a literal. Did you mean "=="?
letsencrypt_proxy    |   if self.email is '' or self.token is '':
letsencrypt_proxy    | /usr/lib/python3.8/site-packages/CloudFlare/cloudflare.py:89: SyntaxWarning: "is" with a literal. Did you mean "=="?
letsencrypt_proxy    |   if self.email is '' or self.token is '':
letsencrypt_proxy    | /usr/lib/python3.8/site-packages/CloudFlare/cloudflare.py:113: SyntaxWarning: "is" with a literal. Did you mean "=="?
letsencrypt_proxy    |   if self.certtoken is '' or self.certtoken is None:
letsencrypt_proxy    | Saving debug log to /var/log/letsencrypt/letsencrypt.log
letsencrypt_proxy    | Plugins selected: Authenticator standalone, Installer None
letsencrypt_proxy    | Obtaining a new certificate
letsencrypt_proxy    | Performing the following challenges:
letsencrypt_proxy    | http-01 challenge for tomasko.eu
letsencrypt_proxy    | Waiting for verification...
letsencrypt_proxy    | Cleaning up challenges
letsencrypt_proxy    | IMPORTANT NOTES:
letsencrypt_proxy    |  - Congratulations! Your certificate and chain have been saved at:
letsencrypt_proxy    |    /etc/letsencrypt/live/example.com/fullchain.pem
letsencrypt_proxy    |    Your key file has been saved at:
letsencrypt_proxy    |    /etc/letsencrypt/live/example.com/privkey.pem
letsencrypt_proxy    |    Your cert will expire on 2020-04-09. To obtain a new or tweaked
letsencrypt_proxy    |    version of this certificate in the future, simply run certbot
letsencrypt_proxy    |    again. To non-interactively renew *all* of your certificates, run
letsencrypt_proxy    |    "certbot renew"
letsencrypt_proxy    |  - Your account credentials have been saved in your Certbot
letsencrypt_proxy    |    configuration directory at /etc/letsencrypt. You should make a
letsencrypt_proxy    |    secure backup of this folder now. This configuration directory will
letsencrypt_proxy    |    also contain certificates and private keys obtained by Certbot so
letsencrypt_proxy    |    making regular backups of this folder is ideal.
letsencrypt_proxy    |  - If you like Certbot, please consider supporting our work by:
letsencrypt_proxy    | 
letsencrypt_proxy    |    Donating to ISRG / Let's Encrypt:   https://letsencrypt.org/donate
letsencrypt_proxy    |    Donating to EFF:                    https://eff.org/donate-le
letsencrypt_proxy    | 
letsencrypt_proxy    | New certificate generated; starting nginx
letsencrypt_proxy    | Starting 2019/12/30, GeoIP2 databases require personal license key to download. Please manually download/update the GeoIP2 db and save as /config/geoip2db/GeoLite2-City.mmdb
letsencrypt_proxy    | [cont-init.d] 50-config: exited 0.
letsencrypt_proxy    | [cont-init.d] 99-custom-files: executing... 
letsencrypt_proxy    | [custom-init] no custom files found exiting...
letsencrypt_proxy    | [cont-init.d] 99-custom-files: exited 0.
letsencrypt_proxy    | [cont-init.d] done.
letsencrypt_proxy    | [services.d] starting services
letsencrypt_proxy    | [services.d] done.
letsencrypt_proxy    | nginx: [alert] detected a LuaJIT version which is not OpenResty's; many optimizations will be disabled and performance will be compromised (see https://github.com/openresty/luajit2 for OpenResty's LuaJIT or, even better, consider using the OpenResty releases from https://openresty.org/en/download.html)
letsencrypt_proxy    | Server ready

[aptalca]

I reproduced it on a fresh install. Looks like an upstream issue with some python packages. It seems to be just a warning. We'll look into it.

Thanks

[aptalca]

Here's the python commit that is responsible for printing the warning: python/cpython@3bcbedc

Basically, all those need to be fixed in the upstream apps/plugins

[thrubovc]

I thought as much, it seemed like it was a python 3.8 thing. Thanks for checking

[aptalca]

Submitted PR for cloudflare: cloudflare/python-cloudflare#84
digitalocean: koalalorenzo/python-digitalocean#302

[mackonsti]

Hello, I would like to report the same error on a fresh container run for letsencrypt.
Would this need to be fixed for python3.8 file visitor.py or the linuxserver-provided image for letsencrypt? Just to confirm if there is some fix that we must manually do. Thank you

[aptalca]

Explained above #400 (comment)

[BrightCandle]

I saw this error with a renewal scheduled task today, in the log/letsencrypt logs. No certs were adjusted but it only contained logs for one subdomain repeated across two logs. I don't think the certs are all getting checked or there is a problem with the logs.

The running of the scheduled task certbot, or the error, caused a very weird outage where one of the subdomains was switched onto a different config for a different subdomain (repo suddenly pointed to repo3). The image needed a restart to restore service. I don't know if this is related to the error but the running of the bot coincided with the outage and this is the only log entry amiss I can find. It might indicate it isn't just a warning but a very problematic problem.

This is the second such outage in 2 days. No idea if this error is the cause or it just happens to be at the same moment could be related to the running of the scheduled task itself, but the logs are a little spartan for ascertaining anything else.

[aptalca]

@BrightCandle likely unrelated but you didn't post any logs so I have no idea what's going on

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[aptalca]

Most if not all of these are fixed upstream