Skip to content

Stricter origin parsing and validation#133

Merged
iinuwa merged 5 commits intomainfrom
iinuwa/stricter-origin-parsing
Feb 20, 2026
Merged

Stricter origin parsing and validation#133
iinuwa merged 5 commits intomainfrom
iinuwa/stricter-origin-parsing

Conversation

@iinuwa
Copy link
Member

@iinuwa iinuwa commented Feb 7, 2026

This improves

  • Adds an explicit AppID type
  • Make Origin an enum of either HTTPS or AppId
  • Rename RequestEnvironment to NavigationContext
  • Requires AppId requests to set an RP ID explicitly.

RequestEnvironment/NavigationContext mixed the concepts of origin type (HTTPS/AppId) and same/cross-origin context. These two concepts are now split into Origin and NavigationContext more clearly.

msirringhaus
msirringhaus previously approved these changes Feb 9, 2026
Copy link
Collaborator

@msirringhaus msirringhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments

@iinuwa iinuwa requested a review from msirringhaus February 19, 2026 05:21
@iinuwa
Copy link
Member Author

iinuwa commented Feb 20, 2026

I'm going to go ahead and merge this one, since it was previously approved sans formatting and test tweaks.

@iinuwa iinuwa merged commit f40fa6a into main Feb 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments