Skip to content

Conversation

@rammanoj
Copy link
Contributor

@rammanoj rammanoj commented Aug 20, 2025

📝 Description

  • Add label to nodepool
  • Remove redundant assigning of label and taint while creation

✔️ How to Test

What are the steps to reproduce the issue or verify the changes?

  • Run pip install . to install the PR in the local environment.
  • Create an LKE-E Cluster and use the below config to create a nodePool with a label.
  • Create a NodePool with a label using the following code and ensure created nodes contain the label in their name.
client = LinodeClient("<api-token>", "https://api.linode.com/v4beta")
cluster = LKECluster(client, <cluster-id>)
node_pool = cluster.node_pool_create("g6-dedicated-2", 3, label="my-node-pool")
print(node_pool)
  • Update the nodePool, set label to some other value using the following code and ensure the newly created linodes are reflected accordingly.
# set node pool to any other value and increase count so that newly booted machine comes up with updated value
client = LinodeClient("<api-token>", "https://api.linode.com/v4beta")
cluster = LKECluster(client, <cluster-id>)
node_pool = LKENodePool(client,<cluster-id>, <nodepool-id>)
node_pool.label = "other-123-label"
node_pool.count = 4
node_pool.save()
  • Update the nodePool, set label to some other value using the following code and ensure the newly created linodes are reflected accordingly.
# set node pool to any other value and increase count so that newly booted machine comes up with <cluster-id>-<nodepool-id>-<hash>
cluster = LKECluster(client, <cluster-id>)
node_pool = LKENodePool(client,<cluster-id>, <nodepool-id>)
node_pool.label = ""
node_pool.count = 5
node_pool.save()

How do I run the relevant unit/integration tests?

  • Run tox

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@rammanoj rammanoj requested a review from a team as a code owner August 20, 2025 22:52
@rammanoj rammanoj requested review from jriddle-linode and zliang-akamai and removed request for a team August 20, 2025 22:52
Copy link
Member

@zliang-akamai zliang-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works locally, thank you.

@lgarber-akamai lgarber-akamai merged commit 78ae618 into linode:dev Aug 22, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants