This repository was archived by the owner on Sep 11, 2020. It is now read-only.
Added option to create image URL from the upload response#495
Open
mudivili wants to merge 1 commit intolinkesch:masterfrom
Open
Added option to create image URL from the upload response#495mudivili wants to merge 1 commit intolinkesch:masterfrom
mudivili wants to merge 1 commit intolinkesch:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a new option,
returnURLFromUploadResultto create image URL from the upload response.Current code expects the server response to be in a certain format.
In my case, server response is generic & used by make other places in the application.
But it is not in
files: [{url}]format.Provided a fallback based solution. If the
returnURLFromUploadResultis defined, then upload result will be passed to that function & return value is used to set the url.--